[PATCH] D125029: [VPlan] Exit earlier when trying to widen with scalar VFs.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 22 14:39:53 PDT 2022


Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Thanks for following up!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8577
     }
 
       // Record the incoming value from the backedge, so we can add the incoming
----------------
Unrelated nits while we're here: above could benefit slightly from condition reversal, below needs its indentation fixed.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8590
     return toVPRecipeResult(Recipe);
 
+  if (LoopVectorizationPlanner::getDecisionAndClampRange(
----------------
Would be good to add a comment stating that all other "Widen" recipes from here on deal only with VF>1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125029/new/

https://reviews.llvm.org/D125029



More information about the llvm-commits mailing list