[PATCH] D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D125645#3528343 <https://reviews.llvm.org/D125645#3528343>, @mstorsjo wrote:

> In D125645#3528320 <https://reviews.llvm.org/D125645#3528320>, @efriedma wrote:
>
>> Did you consider instead of adding `.seh_endepilogue_nop`, just require writing `.seh_nop; .seh_endepilogue`?  Then we can automatically merge a tailing nop with the "end" opcode.
>
> Hmm, I didn't consider that - as they're separate opcodes in the unwind info, I was kinda led into this format. But that sounds like a good idea - I'll try it out and see if it seems better or not!

Yep, overall that seems to make things even cleaner and looks like a good direction - thanks!

However, doing that exposes a different underlying issue in the handling of the SEH_* machine instructions used in frame lowering that hadn't been a problem so far - I'll follow up in D125648 <https://reviews.llvm.org/D125648> with that issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125645/new/

https://reviews.llvm.org/D125645