[PATCH] D126175: [SelectionDAG] Add a freeze to ISD::ABS expansion.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 22 12:46:45 PDT 2022


craig.topper created this revision.
craig.topper added reviewers: efriedma, RKSimon, spatel.
Herald added subscribers: pmatos, asb, StephenFan, ecnelises, pengfei, hiraditya, jgravelle-google, sbc100, dschuff.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added a subscriber: aheejin.
Herald added a project: LLVM.

I had initially assumed this was the problem with
https://github.com/llvm/llvm-project/issues/55271#issuecomment-1133426243

But it turns out that was a simpler issue. This patch is still
more correct than what we were doing before so figured I'd submit
it anyway.

No test case because I'm not sure how to get an undef around
until expansion.

Looking at the test deltas I wonder if it be valid to combine
(sext_inreg (freeze (aextload X))) -> (freeze (sextload X)).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126175

Files:
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/test/CodeGen/WebAssembly/PR41149.ll
  llvm/test/CodeGen/X86/iabs.ll
  llvm/test/CodeGen/X86/neg-abs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126175.431249.patch
Type: text/x-patch
Size: 4548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220522/c2f7d28e/attachment.bin>


More information about the llvm-commits mailing list