[PATCH] D125777: [llvm-dva] 02 - Driver and documentation

J. Ryan Stinnett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 22 11:09:12 PDT 2022


jryans added a comment.

I've only read through the docs so far. This is looking great overall, and I'm excited for it to land. 😄



================
Comment at: llvm/docs/CommandGuide/llvm-dva.rst:19
+original user source code. Supported object file formats include ELF,
+MacOS, PDB and COFF.
+
----------------
"MacOS" is not an object file format, so probably you mean "Mach-O" here?


================
Comment at: llvm/docs/CommandGuide/llvm-dva.rst:147-148
+ user source code, where the elements are declared or defined; functions
+ with public visibility across modules. These options allow to map the
+ elements to their user code location, for cross references purposes.
+
----------------
Nit: These sentences read a bit strangely


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125777/new/

https://reviews.llvm.org/D125777



More information about the llvm-commits mailing list