[PATCH] D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 21 10:31:59 PDT 2022


MaskRay added a comment.

> However, for proper symbolic disassembly on X86 we need to know both sizes.

Add some description why it is the case. IIUC `InstSize` allows we to know the size of the only operand. If there are multiple operands, we don't know their sizes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126101/new/

https://reviews.llvm.org/D126101



More information about the llvm-commits mailing list