[PATCH] D125075: [X86][AMX] Multiple configure for AMX register.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FastPreTileConfig.cpp:355
+      Shape.getRow()->setIsKill(false);
+      Shape.getCol()->setIsKill(false);
+      RowPHI.addReg(Shape.getRow()->getReg()).addMBB(InMBB);
----------------
xiangzhangllvm wrote:
> The most important change for "kill/dead" , I think, is not here. It should be the "old" last use (if it before current PHI)
Yes, but there should be no side effect to set false. The kill flag should be caluculated during register alloction. 


================
Comment at: llvm/lib/Target/X86/X86FastPreTileConfig.cpp:356-357
+      Shape.getCol()->setIsKill(false);
+      RowPHI.addReg(Shape.getRow()->getReg()).addMBB(InMBB);
+      ColPHI.addReg(Shape.getCol()->getReg()).addMBB(InMBB);
+
----------------
xiangzhangllvm wrote:
> It is possible to extend the row/col reg kill to here.
The kill flag should be caluculated during register alloction. We need to anaylze the live range to know the kill flag. Here I think it is not important to set kill flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125075/new/

https://reviews.llvm.org/D125075