[PATCH] D125899: [ADT] Add copy constructor to IntervalMap
Markus Böck via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 21 04:11:12 PDT 2022
zero9178 added a comment.
If we are implementing a copy constructor now, shouldn't we be following the Rule of 5 (or at least Rule of 3)? In this case that'd mean also implementing the copy assignment operator and ideally move constructor and move assignment operator. This would be especially important if the interval map were to be inside a vector for performance reasons.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125899/new/
https://reviews.llvm.org/D125899
More information about the llvm-commits
mailing list