[PATCH] D126110: [BOLT] Fix AND evaluation bug in shrink wrapping

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 21:37:00 PDT 2022


Amir added a comment.

I'm concerned that the fix is an overkill and doesn't address the root cause.
>From what I understand, `evaluateSimple` can only evaluate a constant when given an instruction it understands and a pair of <reg, val> for use in evaluation. So the problem must be with the calling code – that the value of rsp is considered a constant while it's actually not (at least not in this case).

Even if it's not the case, I would like to keep the evaluation of `and` – it might be handy in other contexts – but restrict shrink-wrapping from using it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126110/new/

https://reviews.llvm.org/D126110



More information about the llvm-commits mailing list