[PATCH] D126088: [RISCV] Add clarifying asserts to getFrameIndexReference [NFC]

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 13:12:46 PDT 2022


reames created this revision.
reames added reviewers: frasercrmck, craig.topper, kito-cheng, asb.
Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, bollu, simoncook, johnrusso, rbar, hiraditya, arichardson, mcrosier.
Herald added a project: All.
reames requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

This reorganizes comments slightly (to make the key difference between two big blocks more obvious), and adds some clarifying asserts.   This is motivated by me trying to wrap my head around the code enough to usefully review D125787 <https://reviews.llvm.org/D125787>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126088

Files:
  llvm/lib/Target/RISCV/RISCVFrameLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126088.431035.patch
Type: text/x-patch
Size: 5139 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220520/27ba9174/attachment-0001.bin>


More information about the llvm-commits mailing list