[PATCH] D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 12:32:43 PDT 2022


efriedma added a comment.

Did you consider instead of adding `.seh_endepilogue_nop`, just require writing `.seh_nop; .seh_endepilogue`?  Then we can automatically merge a tailing nop with the "end" opcode.



================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:12113
+    if (Reg == 15) // pc -> lr
+      Reg = 14;
+    if (Reg == 13)
----------------
Do we really need the `pc -> lr` remapping, as opposed to just forbidding users from specifying `pc`?  Seems a little weird to have multiple ways to write the same unwind code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125645/new/

https://reviews.llvm.org/D125645



More information about the llvm-commits mailing list