[PATCH] D125905: [RISCV] Fix state persistence bugs (PR55548)

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:236
+    MCTargetStreamer &TS = *getTargetStreamer();
+    RISCVTargetStreamer &RTS = static_cast<RISCVTargetStreamer &>(TS);
+    RTS.reset();
----------------
RTS should be omitted.


================
Comment at: llvm/test/MC/RISCV/twice.ll:1
+; Check for state persistence bugs in the RISC-V MC backend
+; This should neither fail (in the comparison that the second object
----------------
In some directories, the `## ` style is used to make comments stand out from RUN/CHECK lines. MC/RISCV. It will also make `update_*checks.py`'s job easy.

---

I feel that CodeGen/RISCV may be more suitable but I can be persuaded that MC/RISCV is fine.


================
Comment at: llvm/test/MC/RISCV/twice.ll:10
+
+; CHECK: Sections:
+; CHECK-NEXT: Idx Name              Size     VMA              Type
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125905/new/

https://reviews.llvm.org/D125905