[PATCH] D126079: [NFC][LLVM] Renmae all shouldExpandAtomic*InIR to shouldExpandAtomicInstInIR

Shilei Tian via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 11:38:45 PDT 2022


tianshilei1992 added a comment.

In D126079#3528179 <https://reviews.llvm.org/D126079#3528179>, @jyknight wrote:

> IMO, this change hurts the readability of the code, not improves it.

We already have the instruction information in the argument, and it is the only argument, is it necessary to encode it in the function name as well? One of the advantages having overloaded function is that we don't need to write a series of functions with different names whose only difference is just the argument type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126079/new/

https://reviews.llvm.org/D126079



More information about the llvm-commits mailing list