[PATCH] D125977: [AArch64] Remove references to Streaming SVE from target features.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-counting-elems.ll:5
+; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sme < %s | FileCheck %s
+; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sme -mattr=+use-scalar-inc-vl < %s | FileCheck %s -check-prefix=USE_SCALAR_INC
 
----------------
Probably a future patch but `+sme` should really imply `+use-scalar-inc-vl` as it does for `+sve2`.


================
Comment at: llvm/test/MC/AArch64/SME/feature.s:5
 
-// Verify +sme flags imply +streaming-sve
+// Verify +sme flags imply +sme
 tbx z0.b, z1.b, z2.b
----------------
I think you meant `+sve` here?


================
Comment at: llvm/test/MC/AArch64/SME/streaming-mode-neon-bf16.s:3-4
 // RUN:        | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST
-// RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=-neon,+streaming-sve,+bf16 < %s \
+// RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=-neon,+sme,+bf16 < %s \
 // RUN:        | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST
 // RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=-neon < %s 2>&1 \
----------------
It looks like we have `+sme` implying `+bf16` so can this `RUN` line be removed and the `+bf16` removed from the other `RUN` lines?


================
Comment at: llvm/test/MC/AArch64/SME/streaming-mode-neon.s:3-4
 // RUN:        | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST
-// RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=-neon,+streaming-sve < %s \
+// RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=-neon,+sme < %s \
 // RUN:        | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST
 // RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=-neon < %s 2>&1 \
----------------
This is now a duplicate of the previous run line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125977/new/

https://reviews.llvm.org/D125977