[PATCH] D126025: AMDGPU: allow reordering of functions in AMDGPUResourceUsageAnalysis

[Jacob Weightman via Phabricator via llvm-commits]

jweightman marked an inline comment as done.
jweightman added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/hsa-metadata-resource-usage-function-ordering.ll:22
+; CHECK:   - .args:
+; CHECK:     .private_segment_fixed_size: 0
+define amdgpu_kernel void @test2() {
----------------
arsenm wrote:
> Checking the stack size is 0 isn’t going to be a reliable check since we’re going to stop adding an arbitrary constant for unknown stack size and reporting dynamic stack separately. I’d prefer to have some register count checks too
@arsenm I added the register count checks, but I'm not sure how to make the stack size check more reliable at the moment. Could you clarify a few questions, so I can improve the test?

> we’re going to stop adding an arbitrary constant for unknown stack size and reporting dynamic stack separately

This sounds like unknown calls will contribute 0 to the private segment fixed size, and there will be some other field that describes dynamic stack usage separately. What will this field be called? What values will it be able to have, and what will they mean?

Also, if this isn't implemented yet, how can I write a check for it or future-proof this test now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126025/new/

https://reviews.llvm.org/D126025