[PATCH] D126069: Test stackmap support for i128

Edd Barrett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 07:42:29 PDT 2022


vext01 created this revision.
vext01 added a reviewer: reames.
Herald added subscribers: pengfei, kbarton, nemanjai.
Herald added a project: All.
vext01 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This diff adds tests that check the currently-working stackmap cases for i128. This will help ensure no regressions are later introduced by D125680 <https://reviews.llvm.org/D125680> (when ready).

Note that i128 stackmap support is currently incomplete, so we cant test all i128 functionality:

- i128 constants >= 2^{63} crash LLVM <https://github.com/llvm/llvm-project/issues/55609>
- non-constant i128s crash LLVM <https://github.com/llvm/llvm-project/issues/26431#issuecomment-1132697106>

So this change tests only constant i128 operands of value < 2^{63}.

A couple of incorrect comments are also fixed.


https://reviews.llvm.org/D126069

Files:
  llvm/test/CodeGen/AArch64/arm64-stackmap.ll
  llvm/test/CodeGen/AArch64/stackmap.ll
  llvm/test/CodeGen/PowerPC/ppc64-stackmap.ll
  llvm/test/CodeGen/SystemZ/stackmap.ll
  llvm/test/CodeGen/X86/stackmap.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126069.430967.patch
Type: text/x-patch
Size: 10145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220520/9f9fb723/attachment.bin>


More information about the llvm-commits mailing list