[PATCH] D125787: [RISCV] Fix RVV stack frame alignment bugs

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 07:04:30 PDT 2022


StephenFan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:753
       // | scalar local variables   | | <----'
       // |--------------------------| -- <-- SP
     }
----------------
If I didn't misunderstand, the SP here is assumed that align to maxalign, which is the max alignment of all stack objects (including rvv stack objects). But I found https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/MachineFrameInfo.cpp#L61 only records max align on non-scalable stack objects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125787/new/

https://reviews.llvm.org/D125787



More information about the llvm-commits mailing list