[PATCH] D126025: AMDGPU: allow reordering of functions in AMDGPUResourceUsageAnalysis

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/hsa-metadata-resource-usage-function-ordering.ll:1
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx700 --amdhsa-code-object-version=4 -enable-misched=0 -filetype=obj -o - < %s | llvm-readelf --notes - | FileCheck %s
+; RUN: llc -mattr=-xnack -mtriple=amdgcn-amd-amdhsa --amdhsa-code-object-version=4 -mcpu=gfx803 -enable-misched=0 -filetype=obj -o - < %s | llvm-readelf --notes - | FileCheck %s
----------------
Can you use the explicit external size flag so this test breaks when it’s removed?


================
Comment at: llvm/test/CodeGen/AMDGPU/hsa-metadata-resource-usage-function-ordering.ll:22
+; CHECK:   - .args:
+; CHECK:     .private_segment_fixed_size: 0
+define amdgpu_kernel void @test2() {
----------------
Checking the stack size is 0 isn’t going to be a reliable check since we’re going to stop adding an arbitrary constant for unknown stack size and reporting dynamic stack separately. I’d prefer to have some register count checks too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126025/new/

https://reviews.llvm.org/D126025