[PATCH] D124804: [Object][DX] Parse DXContainer Parts

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 21:17:45 PDT 2022


beanz added a comment.

In D124804#3526834 <https://reviews.llvm.org/D124804#3526834>, @kuhar wrote:

> In total, I counted ~1500 uses of `ArrayRef<uint8_t>` in the monorepo, so I don't consider it an uncommon pattern.

Scanning the full monorepo is probably not the best measure for stylistic code patterns. The “golden-rule” of LLVM’s style guidelines is to match existing code patterns, and that is generally applied to the code in the area that you’re modifying (https://llvm.org/docs/CodingStandards.html#golden-rule).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124804/new/

https://reviews.llvm.org/D124804



More information about the llvm-commits mailing list