[PATCH] D125036: [RISCV] Alignment relaxation

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 20:07:53 PDT 2022


MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/RISCV.cpp:582
+      if (isec->adjustRanges(adjustRanges)) {
+        script->assignAddresses();
+        changed = true;
----------------
This is inefficient. `relaxOnce` should call script->assignAddresses() at most once. The call should be moved just before return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125036/new/

https://reviews.llvm.org/D125036



More information about the llvm-commits mailing list