[PATCH] D126036: Recommit "[RISCV] Add test cases showing failure to remove mask on rotate amounts."

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 16:57:26 PDT 2022


craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel, niravd.
Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, arichardson.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

With fix for the expensive checks build failure. Something about
expanding two rotates in type legalization caused a change in the
remapping tables that the expensive checks verifying wasn't expecting.
See comment in the code for how it was fixed.

Original commit message:
If the masking AND has multiple users we fail to remove it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126036

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
  llvm/test/CodeGen/RISCV/rotl-rotr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126036.430859.patch
Type: text/x-patch
Size: 12643 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220519/a597f9c3/attachment.bin>


More information about the llvm-commits mailing list