[PATCH] D125421: [TableGen] Add generation of argument register lists

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/utils/TableGen/CallingConvEmitter.cpp:106-108
+                                 std::string Name =
+                                     Class.first->getNameInitAsString();
+                                 return StringRef(Name).startswith("CCIfSwift");
----------------
nickdesaulniers wrote:
> void wrote:
> > nickdesaulniers wrote:
> > > ```
> > > StringRef Name = Class.first->getNameInitAsString();
> > > return Name.startswith("CCIfSwift");
> > > ```
> > > Not sure if that would fit on one line if it was a single statement?
> > It goes over 80 columns.
> I still think the pair of expressions need not make any mention of `std::string` if you just construct a `StringRef` from the get go.
s/expressions/statements/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125421/new/

https://reviews.llvm.org/D125421