[PATCH] D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 12:09:04 PDT 2022


efriedma added a comment.

This makes the names and conventions here seem very confusing.  The function is called WidenVecRes_BinaryCanTrap, but we're dealing with operations that can't actually trap.  And it now has two different ways of unrolling an operation, depending on whether we're generating a libcall: the existing codepath uses smaller vectors, and the new one completely unrolls.

Can we unify the determination of whether we want to generate operations involving undef?  And can we unify how we unroll an operation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125988/new/

https://reviews.llvm.org/D125988



More information about the llvm-commits mailing list