[PATCH] D125998: [Metadata] Add a resize capability to MDNodes and add a push_back interface to MDNodes.

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp created this revision.
wolfgangp added a reviewer: dexonsmith.
Herald added a subscriber: hiraditya.
Herald added a project: All.
wolfgangp requested review of this revision.
Herald added a project: LLVM.

See the discussion in D124548 <https://reviews.llvm.org/D124548>.

This patch depends on D125994 <https://reviews.llvm.org/D125994> (the copy/move constructors and assignment ops for MDOperand).
Some notes:

- I have a slight preference for the term "resizable" over "dynamic", but I'd be happy to change it if you feel strongly about it.
- I only introduced a push_back() instead of append() for now. Could be introduced incrementally.
- Don't know if more tests are needed at a deeper level, but it seems all of the code is exercised except perhaps some assertions that are difficult to enfore (e.g. alignment).
- @dexonsmith You mentioned that phabricator reviews can be linked. I'm having trouble finding out how.


https://reviews.llvm.org/D125998

Files:
  llvm/include/llvm/IR/Metadata.h
  llvm/lib/IR/Metadata.cpp
  llvm/unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125998.430748.patch
Type: text/x-patch
Size: 14731 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220519/14cc25a3/attachment.bin>