[PATCH] D125992: [AMDGPU] gfx11 FLAT Instructions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:63
 
+  bits<1> has_sve  = 0; // Scratch VGPR Enable
+  bits<1> sve = 0;
----------------
This is duplicate of the same declarations above.


================
Comment at: llvm/test/MC/AMDGPU/flat-gfx11-mnemonic.s:1
+// RUN: not llvm-mc -arch=amdgcn -mcpu=gfx1100 -show-encoding %s | FileCheck --check-prefix=GFX11 %s
+
----------------
It should not be 'not llvm-mc' as long as it is a positive test.


================
Comment at: llvm/test/MC/AMDGPU/flat-gfx11-mnemonic.s:3
+
+
+// FLAT
----------------
Single blank line.


================
Comment at: llvm/test/MC/AMDGPU/flat-gfx11-mnemonic.s:6
+
+
+flat_load_ubyte v1, v[4:5]
----------------
Single blank line.


================
Comment at: llvm/test/MC/AMDGPU/flat-gfx11-mnemonic.s:63
+// GFX11: encoding: [0xff,0x47,0x08,0xdd,0x03,0x05,0x7c,0x01]
+
+
----------------
Ditto.


================
Comment at: llvm/test/MC/AMDGPU/flat-gfx11.s:5
+// RUN: not llvm-mc -arch=amdgcn -mcpu=gfx1030 2>&1 %s | FileCheck --check-prefix=VI-GFX9_10-ERR --implicit-check-not=error: %s
+// RUN: not llvm-mc -arch=amdgcn -mcpu=gfx1100 -show-encoding %s | FileCheck --check-prefix=GFX11 %s
+
----------------
Ditto 'not'


================
Comment at: llvm/test/MC/AMDGPU/gfx11_flat.s:1
+// RUN: llvm-mc -arch=amdgcn -mcpu=gfx1100 -mattr=+wavefrontsize32,-wavefrontsize64 -show-encoding %s | FileCheck --check-prefix=GFX11 %s
+// RUN: llvm-mc -arch=amdgcn -mcpu=gfx1100 -mattr=-wavefrontsize32,+wavefrontsize64 -show-encoding %s | FileCheck --check-prefix=GFX11 %s
----------------
There seems to be too much tests doing the same, isn't it?


================
Comment at: llvm/test/MC/Disassembler/AMDGPU/flat-gfx11.txt:3
+
+
+# FLAT
----------------
Single blank line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125992/new/

https://reviews.llvm.org/D125992