[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

Thu May 19 11:00:17 PDT 2022

hctim added a comment.

In D123534#3525533 <https://reviews.llvm.org/D123534#3525533>, @paulkirth wrote:

> We noticed when building Fuchsia using ToT LLVM that CGo has trouble with the new changes to DWARF introduced in this patch. It appears as if CGo is confused because it found a `DW_TAG_variable` that doesn't have a name, which is allowed by the DWARF standard.
>
> This  patch seems like a good change to me and is well thought out and tested, but I think this may cause issues in the wider ecosystem as people interact with it. It may simply be a problem w/ Go, and a bug fix there is all that is necessary,  but there is also the chance that other compilers and toolchains will have similar issues.
>
> I want to be clear that I don't necessarily think a revert is in order, but we should take the opportunity to determine the right course of action.

Thanks for the heads up. A possible thought is to send an announcement of "this happened" to llvm-dev, but I'm not sure that would reach the intended audience, as LLVM tooling is effectively "fixed up" inside this patch, and it's more the consumers of LLVM that may need changes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123534/new/

https://reviews.llvm.org/D123534