[PATCH] D124728: Allow pointer types for atomicrmw xchg

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 08:42:40 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:523
   // This code can go away when cmpxchg supports FP types.
-  bool NeedBitcast = OrigTy->isFloatingPointTy();
+  bool NeedBitcast = OrigTy->isFloatingPointTy() || OrigTy->isPointerTy();
   if (NeedBitcast) {
----------------
Is this change necessary?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124728/new/

https://reviews.llvm.org/D124728



More information about the llvm-commits mailing list