[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-fnabs.ll:46
+; RUN:   -mattr=-vsx < %s | FileCheck %s --check-prefix=CHECK-NOVSX
+
+declare double @llvm.ppc.fnabs(double)
----------------
lei wrote:
> nit: same as before no need to test all combination for both pwr7 and pwr8.  Just a mix of the 2 like in the clang test. What happens if we do pwr6 with `+vsx`?  Is this a possible combination?
Thanks Lei, I'll update those lines. We also discussed outside of this review that adding a P6 and VSX line results in `xsnabsdp` and it wouldn't hurt to add it here too, so I'll add one line for that, as well. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125506/new/

https://reviews.llvm.org/D125506