[PATCH] D125907: [AMDGPU][MC][GFX8+] Correct SMEM offset parsing

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:7733
 bool AMDGPUOperand::isSMEMOffset() const {
-  return isImm(); // Offset range is checked later by validator.
+  return isImm() && !isCPol(); // Offset range is checked later by validator.
 }
----------------
Can we just say something like `isImmTy(ImmTyNone) || isImmTy(ImmTyOffset)`? The way it is, it's not clear what's so special about cache policies in relation with SMEM offsets.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125907/new/

https://reviews.llvm.org/D125907