[PATCH] D125819: [GISel] Add new combines for G_FMINNUM/MAXNUM and G_FMINIMUM/MAXIMUM
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 19 00:54:58 PDT 2022
foad added inline comments.
================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:894
+def combine_minmax_nan_matchinfo: GIDefMatchData<"unsigned">;
+def combine_minmax_nan: GICombineRule<
----------------
There is a standard unsigned_matchinfo you can use instead of defining your own.
================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:5608
+ default:
+ return false;
+ case TargetOpcode::G_FMINNUM:
----------------
This could be llvm_unreachable
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125819/new/
https://reviews.llvm.org/D125819
More information about the llvm-commits
mailing list