[PATCH] D125083: [RISCV] Use check-prefixes to reduce check lines
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 19 00:19:28 PDT 2022
frasercrmck added inline comments.
================
Comment at: llvm/test/CodeGen/RISCV/double-arith-strict.ll:4
; RUN: -disable-strictnode-mutation -target-abi=ilp32d \
-; RUN: | FileCheck -check-prefix=RV32IFD %s
+; RUN: | FileCheck -check-prefixes=CHECK,RV32IFD %s
; RUN: llc -mtriple=riscv64 -mattr=+d -verify-machineinstrs < %s \
----------------
I think `CHECK` only fits if it's common to all RUN lines in the test. Here I'd prefer `CHECKIFD`, for instance, as it's a combined check for the IFD cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125083/new/
https://reviews.llvm.org/D125083
More information about the llvm-commits
mailing list