[PATCH] D125847: LTO: Enable opaque pointers by default.

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 23:42:26 PDT 2022


aeubanks added a comment.

In D125847#3523502 <https://reviews.llvm.org/D125847#3523502>, @MatzeB wrote:

>> +1 to adding something to lto::Config.
>
> Do we really need this for a temporary switch? Will this force us to keep supporting the new switch into the future for backwards compatibility in the commandline interface even when we dropped all references to typed pointers from LLVM?

You mentioned that `-mllvm -opaque-pointers=0` is a temporary workaround with this patch, but `-mllvm -opaque-pointers=1` works just fine for what this patch is trying to do. I think respecting `-Xclang -[no-]opaque-pointers` when performing LTO is desirable, and for that you'd need the `lto::Config` change.

We've removed a bunch of legacy/new pass manager switches, I don't see why we'd keep this switch around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125847/new/

https://reviews.llvm.org/D125847



More information about the llvm-commits mailing list