[PATCH] D125766: [llvm-reduce] improve bb removal

Markus Lavin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 23:16:29 PDT 2022


markus added a comment.

In D125766#3522764 <https://reviews.llvm.org/D125766#3522764>, @arsenm wrote:

> If you blindly scan forward, you're going to run into blocks that have phis that are now missing an input for the new predecessor

Yes, absolutely. Since IR verification happens afterwards the reduction is still going to be rejected but of course if we take more care then we can find a reduction that has less risk of failing verification and might lead us down a fruitful path.
So in a way I would consider this an improvement over the current behavior anyway but while we are at it can certainly be improved a bit further. Will address that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125766/new/

https://reviews.llvm.org/D125766



More information about the llvm-commits mailing list