[PATCH] D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui

[Pretty-box via Phabricator via llvm-commits]

Pretty-box added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:686
+  } else if (NewOpc == ISD::VP_FPTOSI || NewOpc == ISD::VP_FPTOUI)
+    Res = DAG.getNode(NewOpc, dl, NVT, {N->getOperand(0), N->getOperand(1),
+                      N->getOperand(2)});
----------------
craig.topper wrote:
> That's not what I meant.
> 
> I meant to be curly braces around the DAG node calls. LLVM coding standards say that if the `if` needs curly braces each of the `else`s do too.
> 
> See the 4th example here https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements  "Use braces for the `if` block to keep it uniform with the else block."
Done. Thank you for your detailed explanation. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125760/new/

https://reviews.llvm.org/D125760