[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 16:35:20 PDT 2022


efriedma added a comment.

I don't really understand how this is supposed to interact with D125292 <https://reviews.llvm.org/D125292>; even if you strip the readnone attribute from the call instruction, we'll still treat a call to the intrinsic as readnone.

I think I'd prefer to lower the intrinsic as part of the codegen optimization pipeline, not the optimization pipeline.  So maybe just in in SelectionDAG?  I mean, it doesn't matter much for your planned usage in coroutines, but it's more similar to other intrinsics, and more like what we expect it to look like in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125291/new/

https://reviews.llvm.org/D125291



More information about the llvm-commits mailing list