[PATCH] D125918: [LV] Improve register pressure estimate at high VFs

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:385
 
   InstructionCost getRegUsageForType(Type *Ty) {
+    EVT ETy = getTLI()->getValueType(DL, Ty);
----------------
I lack some historical knowledge here but I agree it does look like the current implementation is answering the wrong question here.

Assuming others agree with the intent of the change I'm thinking the function definition should also be changed.  Returning `InstructionCost` seems wrong and likely just the result of the original call to `getTypeLegalizationCost()`.  I think `unsigned` is more representative of the function's intent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125918/new/

https://reviews.llvm.org/D125918