[PATCH] D124895: [Object] Fix updating darwin archives

[James Y Knight via Phabricator via llvm-commits]

jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.

LGTM, modulo final comments.



================
Comment at: llvm/include/llvm/Object/ArchiveWriter.h:29
 
+  object::Archive::Kind getKind() const;
+
----------------
Please add a comment describing what this does.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:49
 
+object::Archive::Kind NewArchiveMember::getKind() const {
+  auto MemBufferRef = this->Buf->getMemBufferRef();
----------------
This isn't a great name because it sounds like a simple accessor, but it's not at all. Maybe `detectKindFromObjectFormat()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124895/new/

https://reviews.llvm.org/D124895