[PATCH] D125905: [RISCV] Fix state persistence bugs (PR55548)

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 09:57:58 PDT 2022


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:234
 
+  // Reset any state
+  void reset() override {
----------------
What does this comment achieve?


================
Comment at: llvm/test/MC/RISCV/twice.ll:21
+target datalayout = "e-m:e-p:64:64-i64:64-i128:128-n64-S128"
+target triple = "riscv64-unknown-linux-gnu"
----------------
Use -mtriple=riscv64 in the llc command and drop these two lines?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125905/new/

https://reviews.llvm.org/D125905



More information about the llvm-commits mailing list