[PATCH] D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 09:09:01 PDT 2022


kparzysz abandoned this revision.
kparzysz added a comment.

In D125611#3520595 <https://reviews.llvm.org/D125611#3520595>, @dblaikie wrote:

> That seems likely to be a better solution - if that's closer to the root cause, less chance someone else will introduce a similarly problematic use of IntervalMap that way (since the use will be no longer problematic).

I chose this approach because I wanted the workarounds to be "more superficial", and appear less like a design choice.  I guess it will be a while before all supported FreeBSD versions no longer need it, so it likely does make sense to fix it in one place.

I'm abandoning this review, I have created a new one: https://reviews.llvm.org/D125899.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125611/new/

https://reviews.llvm.org/D125611



More information about the llvm-commits mailing list