[PATCH] D125820: [AMDGPU] gfx11 LDSDIR instructions MC support

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:8821-8831
+  if (!parseExpr(Imm)) {
+    // The operand is optional, if not present default to 0
+    Imm = 0;
+  }
+
+  if (!isUInt<4>(Imm)) {
+    Error(S, "expected a 4-bit value");
----------------
arsenm wrote:
> Missing parse error tests
Apparently this code is dead. Added error tests for the default parser and removed this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125820/new/

https://reviews.llvm.org/D125820