[PATCH] D125896: [LoopUnroll] Freeze tripcount rather than condition

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp:752
+    TripCount = B.CreateFreeze(TripCount);
+    BECount =
+        B.CreateAdd(TripCount, ConstantInt::get(TripCount->getType(), -1));
----------------
Really not a fan of this.  Your duplicating already subtle logic, and loosing the possibility of SCEV simplification on the BE count.

Doing it once makes sense, but maybe expand both and then freeze the results independently?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125896/new/

https://reviews.llvm.org/D125896