[PATCH] D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide

[J. Ryan Stinnett via Phabricator via llvm-commits]

jryans marked 7 inline comments as done.
jryans added inline comments.


================
Comment at: llvm/docs/InstrRefDebugInfo.md:168
+instruction, and MachineFunction::makeDebugValueSubstitution to record the
+mapping between register defines in the old and new instructions. If some
+values computed by the old instruction are no longer computed by the new
----------------
Orlando wrote:
> nit: should register defines be register definitions? I'm not sure if this is just terminology I'm not familiar with.
Ah yes, I believe so, "definition" is the more common term in LLVM and also the more typical way I heard it phrased generally, so I've changed this to match your suggestion. There a few spots that do call them "defines", but my guess it's that's mainly because of the enum value `RegState::Define` perhaps leading people to call them "defines".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113586/new/

https://reviews.llvm.org/D113586