[PATCH] D123087: tests: enable inferattrs in many tests that will need it soon

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 06:57:06 PDT 2022


nikic added a comment.

I think the general preference would be to explicitly add necessary attributes to test cases, rather than running `inferattrs`. In some of these cases it's not clear to me why the test would need extra attributes, e.g. in case of llvm/test/Transforms/MemCpyOpt/memcpy.ll -- it does test `@malloc`, but I don't think it needs anything beyond the `noalias` attribute that's already present.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123087/new/

https://reviews.llvm.org/D123087



More information about the llvm-commits mailing list