[PATCH] D125776: [llvm-dva] 01 - Interval tree

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 05:12:18 PDT 2022


probinson added inline comments.


================
Comment at: llvm/include/llvm/ADT/IntervalTree.h:355
+    // The intervals in S_left and S_right are recursively divided in the
+    // same manner until there are no intervals left.
+
----------------
psamolysov wrote:
> The word `left` has different meaning in the comment: as opposite to the right and `while there is at least one interval`. English is not my native language, and the first time I read the phrase as "there are no intervals in the left side". Could you rewrite the comment a bit?
Maybe "no intervals remaining" would avoid the ambiguity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125776/new/

https://reviews.llvm.org/D125776



More information about the llvm-commits mailing list