[PATCH] D114644: [AMDGPU] Aggressively fold immediates in SIShrinkInstructions

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp:119
+          if (MRI->use_nodbg_empty(Reg))
+            Def->eraseFromParent();
           ++NumLiteralConstantsFolded;
----------------
arsenm wrote:
> Do we have a test where constant folding happens leaving behind debug info?
I don't know. I get the impression that most of the code that ignores debug uses in our backend is just speculative, and never gets exercised in anger.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114644/new/

https://reviews.llvm.org/D114644