[PATCH] D125764: Assert on polymorphic pointer intrinsic param

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D125764#3519427 <https://reviews.llvm.org/D125764#3519427>, @thopre wrote:

> In D125764#3519318 <https://reviews.llvm.org/D125764#3519318>, @nikic wrote:
>
>> Could you please share an example of a problematic intrinsic signature?
>
>
>
>   def int_colossus_ststep :
>     Intrinsic<
>       [LLVMPointerType<llvm_any_ty>],
>       [llvm_any_ty,
>        LLVMPointerType<LLVMMatchType<0>>,
>        llvm_i32_ty],
>       [IntrWriteMem, IntrArgMemOnly]>;

Okay, I don't think I really understand the issue you're fixing then. This kind of intrinsic declaration //should// work with opaque pointers. The `LLVMMatchType<0>` predicate inside `LLVMPointerType<>` should just be ignored, which is what the current code is doing (right?)

It looks like we also have some in-tree intrinsics that are using this pattern, such as int_riscv_vlm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125764/new/

https://reviews.llvm.org/D125764