[PATCH] D125856: [RISCV] Add cost model for SK_Reverse

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 00:41:54 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:272
 
+InstructionCost RISCVTTIImpl::getMemoryOpCost(unsigned Opcode, Type *Ty,
+                                              MaybeAlign Alignment,
----------------
Miss_Grape wrote:
> craig.topper wrote:
> > This doesn't seem to go with the title of this patch.
> To ensure that the Load/store's InstructionCost‘s state is set to Valid, when  VF.isScalar() == true
Can you put it in a different patch that is applied before this one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125856/new/

https://reviews.llvm.org/D125856



More information about the llvm-commits mailing list