[PATCH] D125656: [RISCV][NFC] Use more Arrayref in TargetLowering functions.
Jianjian Guan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 18 00:38:29 PDT 2022
jacquesguan added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:285
- static constexpr ISD::NodeType FPLegalNodeTypes[] = {
ISD::FMINNUM, ISD::FMAXNUM, ISD::LRINT,
----------------
reames wrote:
> Er, this looks like an undesirable change. Could we add a typed overload for setOperationAction instead?
Do you mean create a new function with `ArrayRef<ISD::NodeType>` as argument? I think this may cause ambiguous calling when we use `setOperationAction` with a single `ISD::NodeType`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125656/new/
https://reviews.llvm.org/D125656
More information about the llvm-commits
mailing list