[PATCH] D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop

[Sun Ziping via Phabricator via llvm-commits]

sunziping2016 added a comment.

In D125522#3521143 <https://reviews.llvm.org/D125522#3521143>, @sameerds wrote:

> I think the change description is missing the point and needs to be rephrased. The modified function was incorrectly (not unnecessarily) ignoring grandchild loops, and this change fixes the bug. In particular, this fixes the handling of the loop { inner, body }. The TODO in the same function is talking about the b1 self loop, which may be "unnecessarily" lost, but that is a different issue.
>
> A possible wording would be: "ensure that loop subtree under child is correctly reconnected to new loop"

Sorry, I'm new here, so I know little about the workflows. I've just updated the title and the summary of this revision. I don't know whether you mean this. And I've noticed there is a build failure on x64 debian. Should I fix this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125522/new/

https://reviews.llvm.org/D125522