[PATCH] D125730: [WebAssembly] Strip TLS when "atomics" is not enabled

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 21:39:05 PDT 2022


sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

The addition of `-mcpu` seem seperate to the TLS issue.. maybe it can land separately?  I wonder if we should rename or alias `mvp` to something more widely understandable such as `v1` ?



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:211
 
     if (!Features[WebAssembly::FeatureBulkMemory])
+      StrippedTLS |= stripThreadLocals(M);
----------------
Why not `else if` here and avoid running `stripThreadLocals` twice?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125730/new/

https://reviews.llvm.org/D125730



More information about the llvm-commits mailing list