[PATCH] D125746: [PowerPC] Treat llvm.fmuladd intrinsic as using CTR

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp:505
+              return true;
+            else
+              LLVM_FALLTHROUGH;
----------------
shchenz wrote:
> no need for `else`. 
> And why we need `LLVM_FALLTHROUGH`, I don't see any handling for `Intrinsic::fmuladd` in the switch block below, will `break` work?
Here `FALLTHROUGH` sets `Opcode = ISD::FMA` for `fmuladd`. Code below checks whether `Opcode` is legal or custom, otherwise returns true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125746/new/

https://reviews.llvm.org/D125746